Help with raising a PR on the SAFE Network GitHub repository

General Beginners
1

Hello there :wave:

Could someone tell me whether there any restrictions on the safe_network repo (https://github.com/maidsafe/safe_network) in terms of who can create and push to remote branches?

I wanted to open a really small pull request, so I cloned the repo, created a new branch and made my changes. Then, to push my branch and set the remote as upstream I called:

git push --set-upstream origin docs-fix-small-readme-typo

However that gives me the below error:

ERROR: Permission to maidsafe/safe_network.git denied to joaoag.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

If someone could let me know whether this is expected or not, if there’s anything I need to do to fix the issue etc. I’d be really grateful. It’s my first time getting involved in open source so very much not in my element here!

My apologies if there’s documentation on this somewhere else and I’ve missed it, I did take a look but couldn’t find anything relating to this.

Thanks in advance : )

2 Likes
2

I’m not sure about the restrictions that exist.

When I create PRs I usually fork the repo to my own account, eg
github.com/iancoleman/safe_network
and then

git remote add origin git@github.com:iancoleman/safe_network
or
git remote set-url origin git@github.com:iancoleman/safe_network

then
git push --set-upstream origin docs-fix-small-readme-typo

Then in the github website for my fork of the repo it shows an option to open a PR.

1 Like
3

Hey @mav :wave:
Thanks so much for getting back to me, appreciate it.
I think you’ve probably identified the issue there - I didn’t use fork, I used clone instead :grimacing:
I’ll try forking and let you know how it goes.
Thanks again

1 Like