WIP: feat(cli): implements 'safe reset' subcommand

[anon78698497]

@joshuef

@joshuef

2021 for copyright notice

Fixed, thanks.

@joshuef

where we’re removing specific files/dirs, does it make sense to print out the path string for each when in dry run mode?

I’d expect dry-run code to do so. That way I can catch if, for example, safe reset would remove a file I hadn’t yet noticed was changed and backed up for later inspection. Or, due to a bug, the working list of paths included something unintended and disastrous to the user’s data.

@joshuef

in a verbose mode perhaps?

I think that without enumerating the FS endpoints to be destroyed, dry-mode wouldn’t have much use would it?

@joshuef

in subcommand/node I think you’ve added a commented line

@anon78698497

The unrelated change in node.rs was to work around a panic on my system.

I caught the repo in a bad state, that workaround isn’t part of my proposed changes and can be ignored.

@bochaco

@bochaco

it’d be nice if we could comment in the PR, is there a way to enable that?

At WIP: feat(cli): implements 'safe reset' subcommand (!1) · Merge requests · Safe Network / sn_api · GitLab “Allows commits from members who can merge to the target branch” is enabled. I’d expect that to include anyone at Members · Safe Network / sn_api · GitLab. Perhaps @frabrunelle would add you there and/or to the organization at Group members · Safe Network · GitLab?

@bochaco

Perhaps we can adapt the prompt_user helper to accept an optional arg

@bochaco

so we have a single helper function covering what prompt_confirmation does too.

They both prompt the user however their logic is different enough that I would keep them separate. I think it’s also more clear to read let result = prompt_confirmation(); than let result = prompt_user(...String::from("confirm"));. That said, it’s your code and I’ll make the change if you decide?

@bochaco

declare it up front as Vec<PathBuf> ?

Fixed, thanks.

@bochaco

As a general comment, shouldn’t we try to remove only the data but not the executables? as it stands it’s more like an uninstallation rather than a reset, I was assuming we wanted something which can clear all data stored by nodes, CLI credentials, but not the actual apps/executables ?

Agreed. I asked for specific FS endpoints in SAFE CLI subcommand suggestions: reset and uninstall - #7 by anon78698497 however only ~/.safe was mentioned. How would you suggest I put together a better list of items to be deleted?