Can't run safe node with sn_node 0.26.16

Think it has to do with this commit in qp2p. Basically, it changed some args to support manual port forwarding (I think before we only supported UPnP port forwarding).

There’s two fixes (I don’t know if they’re being worked on right now). One is sorta the “real” fix and the other just “gets it to work”.

The real fix would be to propogate the changes to sn_node first, allowing manual port forwarding, then propogate those changes to sn_launch_tool in turn. Alternatively, we can change it only in sn_launch_tool for now and the behavior stays the same and we opt not support manual port forwarding until a later date in sn_node or sn_launch_tool.

The latter might be desirable, because some of the comments on the config_handler.rs file in sn_node seem to indicate that MaidSafe is aiming at refactoring that whole file anyway. It uses a bit of a weird parse scheme that doesn’t take full advantage of structopt.

As I mentioned though, I don’t even know if somebody is taking care of this already and if this is a temporary blockage. Maybe @lionel.faber (who authored the qp2p change) or @bochaco (who seems to be the codeowner of sn_launch_tool) knows what the plan/timeline is for propagating those qp2p changes to sn_node or sn_launch_tool. Alternatively, maybe this just slipped through the cracks, in which case I could author a change myself if nobody is working on it, it doesn’t seem like a massive effort.

3 Likes